Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Generates the HTML to publish to GH Pages #116

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Generates the HTML to publish to GH Pages #116

merged 5 commits into from
Dec 19, 2023

Conversation

leordev
Copy link
Member

@leordev leordev commented Dec 15, 2023 •
edited
Loading

Preparing to publish to GH Pages on every new release automatically.

Preview link: https://tbd54566975.github.io/tbdex-js/index.html

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5c73a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@leordev leordev force-pushed the leordev/gh-pages-html branch from 2d88741 to 1c092c0 Compare December 15, 2023 15:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2023-12-15T16:16:20Z e5c73a4

@leordev leordev marked this pull request as ready for review December 15, 2023 15:41
@leordev leordev mentioned this pull request Dec 15, 2023
Merged
@leordev
Copy link
Member Author

leordev commented Dec 15, 2023 •
edited
Loading

I want to add a reminder about this PR: #52

While we dont address the re-exporting of protocols on the http packages we will keep seeing duplicated definitions across the docs... http-client and http-server are replicating the protocol definitions...

image

Ideally we want it to be exactly like tbdex-kt docs: https://tbd54566975.github.io/tbdex-kt/index.html

See how lean is the http-client package:
image

cc @KendallWeihe @mistermoe

@leordev leordev mentioned this pull request Dec 15, 2023
Closed
@leordev leordev merged commit e31fa7b into main Dec 19, 2023
9 checks passed
@leordev leordev deleted the leordev/gh-pages-html branch December 19, 2023 02:25
@leordev leordev mentioned this pull request Jan 3, 2024
Closed
diehuxx pushed a commit that referenced this pull request Jan 4, 2024
Merge branch 'main' into vectors-214
27f4ffe 
* main:
  Remove HttpResponse and ErrorResponse from `http-client` types (#124)
  Refactor http client to introduce custom error types (#113)
  Finish validating rfq against provided offering (#120)
  Generates the HTML to publish to GH Pages (#116)
  http-server fixes + some tests (#83)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@angiejones angiejones angiejones approved these changes

@mistermoe mistermoe mistermoe approved these changes

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@jiyoonie9 jiyoonie9 Awaiting requested review from jiyoonie9

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leordev @KendallWeihe @mistermoe @angiejones